Skip to content

refactor: Copy ignoreEmailVerification from option to data #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2024
Merged

refactor: Copy ignoreEmailVerification from option to data #2107

merged 2 commits into from
Apr 13, 2024

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Apr 13, 2024 •
edited
Loading

Pull Request

Issue

Refactor how ignoreEmailVerification data is set, due to #2103 (comment).

Approach

Copy ignoreEmailVerification from option to data already in Parse.User instead of later in RESTController.

TODO

  • Docs

@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 13, 2024 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza mtrezza changed the title refactor refactor: copy ignoreEmailVerification from option to data Apr 13, 2024
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: copy ignoreEmailVerification from option to data refactor: Copy ignoreEmailVerification from option to data Apr 13, 2024
@codecov
Copy link

codecov bot commented Apr 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72bc9ac) to head (37ef74a).
Report is 2 commits behind head on alpha.

Additional details and impacted files 
@@             Coverage Diff             @@
##            alpha     #2107      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files          61        61              
  Lines        6185      6185              
  Branches     1499      1499              
===========================================
+ Hits         6184      6185       +1     
+ Misses          1         0       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza requested a review from dplewis April 13, 2024 18:55
@mtrezza mtrezza merged commit a7b2fa0 into parse-community:alpha Apr 13, 2024
@mtrezza mtrezza deleted the refactor/verify-email branch April 13, 2024 20:28
@mtrezza mtrezza mentioned this pull request Apr 13, 2024
Closed
4 tasks
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 13, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 16, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dplewis dplewis dplewis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtrezza @parseplatformorg @dplewis